Refactoring to extract Lrama::Grammar::Symbols #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I think separating Symbol generation code into Can I ask you to
|
…ate processing to the resolver * Move all Symbol generation code, including #fill_symbol_number and so on, into Resolver * Remove Symbols::Base, Symbols::Nterms and Symbols::Terms * Keep Grammar#terms and Grammar#tnerms both of them will be delegated to symbols_resolver
|
Fix to remove Symbols:: Base, Symbols:: Nterms, and Symbols:: Terms to delegate processing to resolvers. What do you think? Please point out if I missed something. |
yui-knk
reviewed
Feb 6, 2024
|
Left one comment, other seems good. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.