Set correct uplevel to warning on supply_default_content_type #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes uplevel of
supply_default_content_type
.Problem
Currently
supply_default_content_type
specifies an incorrectuplevel
towarn
method.For example:
The warning points to
net/http/generic_request.rb
which is not written by the user. The location is not helpful to fix the warning by the user.Solution
Find the correct
uplevel
from the caller and specify it.I also considered using a fixed
uplevel
for it, likeuplevel: 6
. But I thinkcaller_location
is better than the fixed value.Because the
uplevel
is too deep, andsupply_default_content_type
is called from multiple places so the fixed value doesn't work properly for all callers perhaps.