Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on this stackoverflow thread, the
no_proxy
environment variable defines a list of hosts, for which the proxy should be bypassed.The same semantics should probably apply to the
p_no_proxy
parameter ofNet::HTTP
class.At the moment, this method parameter seems to be misinterpreted as a list of proxies that should not be used.
This behaviour was not detected by the existing testcase, because both the destination hostname and the proxy hostname matched the given exclusion suffix.
It might seem surprising that this problem was not detected before, given the long history of the project.
However, the problem only occurs when the proxy is explicitly configured with `Net::HTTP.new(...)``, but not when using the environment variables.