Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Enhanced RDoc for Net::HTTPHeader #79

Merged
merged 5 commits into from
Nov 23, 2022
Merged

[DOC] Enhanced RDoc for Net::HTTPHeader #79

merged 5 commits into from
Nov 23, 2022

Conversation

BurdetteLamar
Copy link
Member

Expands class doc. Treats methods:

  • #[]
  • #[]=
  • #add_field
  • #get_fields
  • #fetch
  • #each_header
  • #each_name
  • #each_capitalized_name

@BurdetteLamar BurdetteLamar added the documentation Improvements or additions to documentation label Nov 19, 2022
lib/net/http/header.rb Outdated Show resolved Hide resolved
lib/net/http/header.rb Outdated Show resolved Hide resolved
lib/net/http/header.rb Show resolved Hide resolved
lib/net/http/header.rb Outdated Show resolved Hide resolved
lib/net/http/header.rb Outdated Show resolved Hide resolved
lib/net/http/header.rb Outdated Show resolved Hide resolved
lib/net/http/header.rb Outdated Show resolved Hide resolved
lib/net/http/header.rb Outdated Show resolved Hide resolved
lib/net/http/header.rb Show resolved Hide resolved
lib/net/http/header.rb Show resolved Hide resolved
@BurdetteLamar
Copy link
Member Author

@peterzhu2118 ready for your review.

@BurdetteLamar BurdetteLamar merged commit 5849e4e into ruby:master Nov 23, 2022
@hsbt
Copy link
Member

hsbt commented Nov 23, 2022

@BurdetteLamar Please do "squash and merge" if you use the same commit message. I still wonder why you don't use it. I'm tired of saying it over and over again.

@BurdetteLamar
Copy link
Member Author

@BurdetteLamar Please do "squash and merge" if you use the same commit message. I still wonder why you don't use it. I'm tired of saying it over and over again.

I thought I had done so (and certainly meant to do so). Is that not the default for the select list in the merge button? If not, can I make it the default (to prevent my making this error in the future)?

@hsbt
Copy link
Member

hsbt commented Nov 23, 2022

I can change default strategy. Is there the reason we change the default configuration for only your mistake?

I also wonder why you still ignore "Please write the meaningful message". You must learn how to use Git and version control of software before the Ruby development.

@peterzhu2118
Copy link
Member

Make sure to use Squash and merge (found in the dropdown menu) before merging. That will prevent this kind of issue in the future.

I don't think there's a feature in GitHub to select a default merge method for your account.

Screenshot 2022-11-23 at 5 11 58 PM

@BurdetteLamar
Copy link
Member Author

I can change default strategy. Is there the reason we change the default configuration for only your mistake?

I also wonder why you still ignore "Please write the meaningful message". You must learn how to use Git and version control of software before the Ruby development.

It might be better if I don't merge at all, but instead ask my wonderful reviewers (like @peterzhu2118, @jeremyevans, and others) to not only review/approve, but also to merge.

It isn't easy, being old. (I'll be 80 in a few weeks.)

@peterzhu2118
Copy link
Member

If you don't feel comfortable merging, I don't mind doing it for you.

@BurdetteLamar
Copy link
Member Author

If you don't feel comfortable merging, I don't mind doing it for you.

Thanks, @peterzhu2118!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

3 participants