replacing all usage of IO.select with the io/wait methods #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hsbt ping |
|
We only accept pull request with test green. You need to investigate test fail. but https://travis-ci.org/ruby/net-telnet/builds/103363183 is not related your changes. I fixed it in master branch. I merge this. |
|
yup, I knew it, that's why I pinged :) problem solved, thx. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in ruby 2.3.0, net/protocol already includes io/wait. One can therefore wait directly on the socket, thereby reducing the array allocations needed for the result and using a cleaner API.