Skip to content

Commit 27efcd7

Browse files
committed
Let OpenSSL choose the digest if digest for Openssl::OCSP::BasicResponse#sign is nil.
1 parent a1f6cbc commit 27efcd7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

ext/openssl/ossl_ocsp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1033,7 +1033,7 @@ ossl_ocspbres_sign(int argc, VALUE *argv, VALUE self)
10331033
if (!NIL_P(flags))
10341034
flg = NUM2INT(flags);
10351035
if (NIL_P(digest))
1036-
md = EVP_sha1();
1036+
md = NULL;
10371037
else
10381038
md = ossl_evp_get_digestbyname(digest);
10391039
if (NIL_P(certs))

test/openssl/test_ocsp.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ def test_request_der
9999
request.sign(@cert, @cert_key, [@ca_cert], 0)
100100
asn1 = OpenSSL::ASN1.decode(request.to_der)
101101
assert_equal cid.to_der, asn1.value[0].value.find { |a| a.tag_class == :UNIVERSAL }.value[0].value[0].to_der
102-
assert_equal OpenSSL::ASN1.ObjectId("sha1WithRSAEncryption").to_der, asn1.value[1].value[0].value[0].value[0].to_der
102+
assert_equal OpenSSL::ASN1.ObjectId("sha256WithRSAEncryption").to_der, asn1.value[1].value[0].value[0].value[0].to_der
103103
assert_equal @cert.to_der, asn1.value[1].value[0].value[2].value[0].value[0].to_der
104104
assert_equal @ca_cert.to_der, asn1.value[1].value[0].value[2].value[0].value[1].to_der
105105
assert_equal asn1.to_der, OpenSSL::OCSP::Request.new(asn1.to_der).to_der

0 commit comments

Comments
 (0)