Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid CSR versions set in regress tests #734

Closed
botovq opened this issue Mar 26, 2024 · 2 comments · Fixed by #747
Closed

Invalid CSR versions set in regress tests #734

botovq opened this issue Mar 26, 2024 · 2 comments · Fixed by #747

Comments

@botovq
Copy link
Contributor

botovq commented Mar 26, 2024

It looks like OpenSSL are about to merge a PR that disallows setting any version but 'version 1' (encoded as 0) in CSRs, because that's the only version specified, see RFC 2986, section 4.1.

This will break at least two regress tests because of:

req = issue_csr(1, @dn, @rsa1024, OpenSSL::Digest.new('SHA256'))

and

req.version = 1

for the second I suggest you find a different way of modifying the CSR.

@job
Copy link
Contributor

job commented Mar 26, 2024

I suspect that this would fix it master...job:ruby-openssl:master

@ioquatix
Copy link
Member

Do you want to submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants