Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl-head: OpenSSL::X509::RequestError: X509_REQ_set_version: passed invalid argument #746

Closed
junaruga opened this issue Apr 24, 2024 · 3 comments

Comments

@junaruga
Copy link
Member

junaruga commented Apr 24, 2024

The following error appeared in the openssl-head (openssl 3.4.0-dev) cases with the latest openssl/openssl master branch commit openssl/openssl@264ff64.

https://github.com/ruby/openssl/actions/runs/8813410629/job/24191105033?pr=745#step:12:624

 2) Error: test_version(OpenSSL::TestX509Request): OpenSSL::X509::RequestError: X509_REQ_set_version: passed invalid argument
/home/runner/work/openssl/openssl/test/openssl/test_x509req.rb:18:in `version='
/home/runner/work/openssl/openssl/test/openssl/test_x509req.rb:18:in `issue_csr'
/home/runner/work/openssl/openssl/test/openssl/test_x509req.rb:43:in `test_version'
     40:     req = OpenSSL::X509::Request.new(req.to_der)
     41:     assert_equal(0, req.version)
     42: 
  => 43:     req = issue_csr(1, @dn, @rsa1024, OpenSSL::Digest.new('SHA256'))
     44:     assert_equal(1, req.version)
     45:     req = OpenSSL::X509::Request.new(req.to_der)
     46:     assert_equal(1, req.version)

As a note, previously the error didn't happen in the openssl-head cases with the openssl/openssl master branch commit openssl/openssl@1967539.

@junaruga junaruga changed the title openssl-head: OpenSSL::X509::RequestError: X509_REQ_set_version: passed invalid argument openssl 3.4.0-dev: OpenSSL::X509::RequestError: X509_REQ_set_version: passed invalid argument Apr 24, 2024
@junaruga junaruga changed the title openssl 3.4.0-dev: OpenSSL::X509::RequestError: X509_REQ_set_version: passed invalid argument openssl-head: OpenSSL::X509::RequestError: X509_REQ_set_version: passed invalid argument Apr 24, 2024
@botovq
Copy link
Contributor

botovq commented Apr 24, 2024

See #734 and #747

@junaruga
Copy link
Member Author

junaruga commented Apr 24, 2024

@botovq thanks for sharing the info, and sending the PR!

@rhenium
Copy link
Member

rhenium commented Apr 26, 2024

GitHub Actions is green with #747. Thank you!

@rhenium rhenium closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants