Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Upgrade OpenSSL and LibreSSL versions. #636

Merged
merged 2 commits into from
Jun 6, 2023
Merged

CI: Upgrade OpenSSL and LibreSSL versions. #636

merged 2 commits into from
Jun 6, 2023

Commits on Jun 5, 2023

  1. CI: Upgrade OpenSSL and LibreSSL versions.

    @junaruga
    junaruga committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    3456770 View commit details
    Browse the repository at this point in the history

  2. Fix modular square root test with LibreSSL >= 3.8 

    If x is a modular square root of a (mod p) then so is (p - x). Both
answers are valid. In particular, both 2 and 3 are valid square roots
of 4 (mod 5). Do not assume that a particular square root is chosen by
the algorithm. Indeed, the algorithm in OpenSSL and LibreSSL <= 3.7
returns a non-deterministic answer in many cases. LibreSSL 3.8 and
later will always return the smaller of the two possible answers. This
breaks the current test case.

Instead of checking for a particular square root, check that the square
of the claimed square root is the given value. This is always true. Add
the simplest test case where the answer is indeed non-deterministic.
    @botovq @junaruga
    botovq authored and junaruga committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    93548ae View commit details
    Browse the repository at this point in the history