Avoid using block_given in the presence of aliases

defined?(yield) bypasses the block_given? method (or any aliases to it) and always does the right thing.
ruby · Mar 31, 2022 · 4c38fe6 · 4c38fe6
1 parent 48d7154
commit 4c38fe6
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/ostruct.rb b/lib/ostruct.rb
@@ -197,7 +197,7 @@ def to_h(&block)
   #   data.each_pair.to_a   # => [[:country, "Australia"], [:capital, "Canberra"]]
   #
   def each_pair
-    return to_enum(__method__) { @table.size } unless block_given!
+    return to_enum(__method__) { @table.size } unless defined?(yield)
     @table.each_pair{|p| yield p}
     self
   end