Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem release latest #11

Closed
headius opened this issue Mar 6, 2020 · 7 comments
Closed

Gem release latest #11

headius opened this issue Mar 6, 2020 · 7 comments
Assignees

Comments

@headius
Copy link
Contributor

headius commented Mar 6, 2020

Seems like this has not had a gem release since 2018, but there are changes in 2.6.x that have not been pushed out.

This is causing spec failures for JRuby, since we now source ostruct from the gem (currently 0.1.0).

@headius
Copy link
Contributor Author

headius commented Mar 6, 2020

Latest specs failing on released ostruct gem (on JRuby):

207)
OpenStruct#to_h with block converts [key, value] pairs returned by the block to a hash FAILED
Expected {:name=>"John Smith", :age=>70, :pension=>300} == {"name"=>"John SmithJohn Smith", "age"=>140, "pension"=>600}
to be truthy but was false
/home/travis/build/jruby/jruby/spec/ruby/library/openstruct/to_h_spec.rb:34:in `block in <main>'
org/jruby/RubyBasicObject.java:2615:in `instance_eval'
org/jruby/RubyEnumerable.java:1862:in `all?'
org/jruby/RubyArray.java:1809:in `each'
org/jruby/RubyArray.java:1809:in `each'
/home/travis/build/jruby/jruby/spec/ruby/library/openstruct/to_h_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:1009:in `load'
org/jruby/RubyBasicObject.java:2615:in `instance_eval'
org/jruby/RubyArray.java:1809:in `each'

208)
OpenStruct#to_h with block raises ArgumentError if block returns longer or shorter array FAILED
Expected ArgumentError ((?-mix:element has wrong array length))
but no exception was raised ({:name=>"John Smith", :age=>70, :pension=>300} was returned)
/home/travis/build/jruby/jruby/spec/ruby/library/openstruct/to_h_spec.rb:38:in `block in <main>'
org/jruby/RubyBasicObject.java:2615:in `instance_eval'
org/jruby/RubyEnumerable.java:1862:in `all?'
org/jruby/RubyArray.java:1809:in `each'
org/jruby/RubyArray.java:1809:in `each'
/home/travis/build/jruby/jruby/spec/ruby/library/openstruct/to_h_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:1009:in `load'
org/jruby/RubyBasicObject.java:2615:in `instance_eval'
org/jruby/RubyArray.java:1809:in `each'

209)
OpenStruct#to_h with block raises TypeError if block returns something other than Array FAILED
Expected TypeError ((?-mix:wrong element type String))
but no exception was raised ({:name=>"John Smith", :age=>70, :pension=>300} was returned)
/home/travis/build/jruby/jruby/spec/ruby/library/openstruct/to_h_spec.rb:48:in `block in <main>'
org/jruby/RubyBasicObject.java:2615:in `instance_eval'
org/jruby/RubyEnumerable.java:1862:in `all?'
org/jruby/RubyArray.java:1809:in `each'
org/jruby/RubyArray.java:1809:in `each'
/home/travis/build/jruby/jruby/spec/ruby/library/openstruct/to_h_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:1009:in `load'
org/jruby/RubyBasicObject.java:2615:in `instance_eval'
org/jruby/RubyArray.java:1809:in `each'

210)
OpenStruct#to_h with block coerces returned pair to Array with #to_ary FAILED
Expected {:name=>"John Smith", :age=>70, :pension=>300} == {:b=>"b"}
to be truthy but was false
/home/travis/build/jruby/jruby/spec/ruby/library/openstruct/to_h_spec.rb:57:in `block in <main>'
org/jruby/RubyBasicObject.java:2615:in `instance_eval'
org/jruby/RubyEnumerable.java:1862:in `all?'
org/jruby/RubyArray.java:1809:in `each'
org/jruby/RubyArray.java:1809:in `each'
/home/travis/build/jruby/jruby/spec/ruby/library/openstruct/to_h_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:1009:in `load'
org/jruby/RubyBasicObject.java:2615:in `instance_eval'
org/jruby/RubyArray.java:1809:in `each'

211)
OpenStruct#to_h with block does not coerce returned pair to Array with #to_a FAILED
Expected TypeError ((?-mix:wrong element type MockObject))
but no exception was raised ({:name=>"John Smith", :age=>70, :pension=>300} was returned)
/home/travis/build/jruby/jruby/spec/ruby/library/openstruct/to_h_spec.rb:64:in `block in <main>'
org/jruby/RubyBasicObject.java:2615:in `instance_eval'
org/jruby/RubyEnumerable.java:1862:in `all?'
org/jruby/RubyArray.java:1809:in `each'
org/jruby/RubyArray.java:1809:in `each'
/home/travis/build/jruby/jruby/spec/ruby/library/openstruct/to_h_spec.rb:4:in `<main>'
org/jruby/RubyKernel.java:1009:in `load'
org/jruby/RubyBasicObject.java:2615:in `instance_eval'
org/jruby/RubyArray.java:1809:in `each'

@headius
Copy link
Contributor Author

headius commented Apr 3, 2020

Ugh. That auto-close is too sensitive.

@headius
Copy link
Contributor Author

headius commented Sep 22, 2020

Pinging again... is there anything I can do to help get this gem released?

@marcandre
Copy link
Member

Sorry @headius, and thanks for the ping.

master is not as I want it right now, I want to fix this week and will release then

@headius
Copy link
Contributor Author

headius commented Sep 22, 2020

Let me know if I can help!

@marcandre
Copy link
Member

I release v0.3.0.
Let me know if you encounter any issue!

headius added a commit to headius/jruby that referenced this issue Oct 5, 2020
An updated release of ostruct is available in 0.3.0, so we can
start sourcing this from the gem.

See ruby/ostruct#11.

See jruby#5576.

See jruby#6161.
@headius
Copy link
Contributor Author

headius commented Oct 5, 2020

Thank you! I've flipped JRuby to using the gem in jruby/jruby#6426 and will merge once it's green. This is the last default gem from 2.6 we needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants