Allow properties to be accessed even when the object is moved to another Ractor #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
reviewed
Aug 19, 2021
I have made the additions as you suggested. Thanks! |
marcandre
approved these changes
Aug 20, 2021
|
Great, thank you! |
Thanks! |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Sep 28, 2021
…s moved to another Ractor (ruby/ostruct#29) ruby/ostruct@d85639f2f5
eregon
reviewed
Oct 6, 2021
| setter_proc = Proc.new {|x| @table[name] = x} | ||
| if defined?(::Ractor) | ||
| ::Ractor.make_shareable(getter_proc) | ||
| ::Ractor.make_shareable(setter_proc) |
There was a problem hiding this comment.
I was thinking this would have the side effect of freezing the OpenStruct instance and @table but actually it does not, which is a CRuby bug: https://bugs.ruby-lang.org/issues/18243
A Ractor should never be able to mutate objects of another Ractor directly of course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having the methods defined using shareable Procs, objects that are moved into another Ractor can still use these methods.