Skip to content

Commit 3ee010b

Browse files
Officially drop support for ruby 2.6 or older
The gem doesn't even install on old rubies, but since the gemspec claims it's supported, `gem install pathname` will try to install it and print an error. This commit doesn't fix the above issue. The only way to fix it would be to restore support and release a new version that actually supports old rubies. However, such a change has been proposed and ignored for a long time. So this issue proposes to leave that broken but at least bring the gemspec manifest and the CI matrix in sync to hopefully avoid this issue from happening again in the future.
1 parent e6b3b3e commit 3ee010b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
name: build (${{ matrix.ruby }} / ${{ matrix.os }})
88
strategy:
99
matrix:
10-
ruby: [ '3.0', head ]
10+
ruby: [ 2.7, '3.0', head ]
1111
os: [ ubuntu-latest, macos-latest, windows-latest ]
1212
exclude:
1313
- { os: windows-latest , ruby: head }

pathname.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Gem::Specification.new do |spec|
77
spec.summary = %q{Representation of the name of a file or directory on the filesystem}
88
spec.description = %q{Representation of the name of a file or directory on the filesystem}
99
spec.homepage = "https://github.com/ruby/pathname"
10-
spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
10+
spec.required_ruby_version = Gem::Requirement.new(">= 2.7.0")
1111
spec.licenses = ["Ruby", "BSD-2-Clause"]
1212

1313
spec.metadata["homepage_uri"] = spec.homepage

test/lib/core_assertions.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -695,7 +695,7 @@ def assert_join_threads(threads, message = nil)
695695
msg = "exceptions on #{errs.length} threads:\n" +
696696
errs.map {|t, err|
697697
"#{t.inspect}:\n" +
698-
RUBY_VERSION >= "2.5.0" ? err.full_message(highlight: false, order: :top) : err.message
698+
err.full_message(highlight: false, order: :top)
699699
}.join("\n---\n")
700700
if message
701701
msg = "#{message}\n#{msg}"

0 commit comments

Comments
 (0)