Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pathname#chdir #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zverok
Copy link

@zverok zverok commented Dec 16, 2023

As it was introduced into Ruby 3.3 as Dir#chdir, and was requested before that in #25.

@zverok zverok requested a review from hsbt December 16, 2023 18:34
@zverok zverok self-assigned this Dec 16, 2023
{
VALUE args[1];

if(rb_block_given_p()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Minor: is the if ( the style used in other conditionals in this file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, indeed! Thank you for noticing.

@toy
Copy link
Contributor

toy commented Dec 27, 2023

Pathname#chdir already existed in ruby till 1.9.1, was obsoleted in 1.8.1 preview and removed in 1.9.2 preview

@zverok
Copy link
Author

zverok commented Dec 27, 2023

@toy Interesting. Do you know the justification? (The obsoleting commit doesn't link to the tracker ticket or ruby-core email discussion) 🤔

@toy
Copy link
Contributor

toy commented Dec 27, 2023

@zverok I remember being frustrated about the change and that justification was something about the method being misplaced, but I failed now to find any more information about it

@hsbt
Copy link
Member

hsbt commented Dec 27, 2023

@toy
Copy link
Contributor

toy commented Dec 27, 2023

@hsbt That one is about removal of methods already marked obsolete, but not why were they marked obsolete

@zverok
Copy link
Author

zverok commented Sep 26, 2024

@hsbt Any updates on this?.. It is a bit weird now that (more simple) Dir object has this method after Ruby 3.3, but (more advanced) Pathname doesn’t.

@hsbt
Copy link
Member

hsbt commented Oct 4, 2024

see #25 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants