Implement Pathname#chdir #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ext/pathname/pathname.c
Outdated
| { | ||
| VALUE args[1]; | ||
|
|
||
| if(rb_block_given_p()) { |
There was a problem hiding this comment.
Very Minor: is the if ( the style used in other conditionals in this file?
There was a problem hiding this comment.
Oh, indeed! Thank you for noticing.
zverok
force-pushed
the
feature-chdir
branch
from
01fc436
to
de4c140
Compare
|
|
|
@toy Interesting. Do you know the justification? (The obsoleting commit doesn't link to the tracker ticket or ruby-core email discussion) 🤔 |
|
@zverok I remember being frustrated about the change and that justification was something about the method being misplaced, but I failed now to find any more information about it |
|
@hsbt That one is about removal of methods already marked obsolete, but not why were they marked obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was introduced into Ruby 3.3 as
Dir#chdir, and was requested before that in #25.