Skip to content

Commit 14e3975

Browse files
committed
Remove Debug::integer_parse
1 parent 486c71c commit 14e3975

File tree

4 files changed

+3
-37
lines changed

4 files changed

+3
-37
lines changed

ext/prism/extension.c

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1065,35 +1065,6 @@ named_captures(VALUE self, VALUE source) {
10651065
return names;
10661066
}
10671067

1068-
/**
1069-
* call-seq:
1070-
* Debug::integer_parse(source) -> [Integer, String]
1071-
*
1072-
* Parses the given source string and returns the integer it represents, as well
1073-
* as a decimal string representation.
1074-
*/
1075-
static VALUE
1076-
integer_parse(VALUE self, VALUE source) {
1077-
const uint8_t *start = (const uint8_t *) RSTRING_PTR(source);
1078-
size_t length = RSTRING_LEN(source);
1079-
1080-
pm_integer_t integer = { 0 };
1081-
pm_integer_parse(&integer, PM_INTEGER_BASE_UNKNOWN, start, start + length);
1082-
1083-
pm_buffer_t buffer = { 0 };
1084-
pm_integer_string(&buffer, &integer);
1085-
1086-
VALUE string = rb_str_new(pm_buffer_value(&buffer), pm_buffer_length(&buffer));
1087-
pm_buffer_free(&buffer);
1088-
1089-
VALUE result = rb_ary_new_capa(2);
1090-
rb_ary_push(result, pm_integer_new(&integer));
1091-
rb_ary_push(result, string);
1092-
pm_integer_free(&integer);
1093-
1094-
return result;
1095-
}
1096-
10971068
/**
10981069
* call-seq:
10991070
* Debug::memsize(source) -> { length: xx, memsize: xx, node_count: xx }
@@ -1376,7 +1347,6 @@ Init_prism(void) {
13761347
// internal tasks. We expose these to make them easier to test.
13771348
VALUE rb_cPrismDebug = rb_define_module_under(rb_cPrism, "Debug");
13781349
rb_define_singleton_method(rb_cPrismDebug, "named_captures", named_captures, 1);
1379-
rb_define_singleton_method(rb_cPrismDebug, "integer_parse", integer_parse, 1);
13801350
rb_define_singleton_method(rb_cPrismDebug, "memsize", memsize, 1);
13811351
rb_define_singleton_method(rb_cPrismDebug, "profile_file", profile_file, 1);
13821352
rb_define_singleton_method(rb_cPrismDebug, "format_errors", format_errors, 2);

include/prism/util/pm_integer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ typedef enum {
8282
* @param start The start of the string.
8383
* @param end The end of the string.
8484
*/
85-
PRISM_EXPORTED_FUNCTION void pm_integer_parse(pm_integer_t *integer, pm_integer_base_t base, const uint8_t *start, const uint8_t *end);
85+
void pm_integer_parse(pm_integer_t *integer, pm_integer_base_t base, const uint8_t *start, const uint8_t *end);
8686

8787
/**
8888
* Return the memory size of the integer.

src/util/pm_integer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ pm_integer_parse_big(pm_integer_t *integer, uint32_t multiplier, const uint8_t *
471471
* has already been validated, as internal validation checks are not performed
472472
* here.
473473
*/
474-
PRISM_EXPORTED_FUNCTION void
474+
void
475475
pm_integer_parse(pm_integer_t *integer, pm_integer_base_t base, const uint8_t *start, const uint8_t *end) {
476476
// Ignore unary +. Unary - is parsed differently and will not end up here.
477477
// Instead, it will modify the parsed integer later.

test/prism/integer_parse_test.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
require_relative "test_helper"
44

5-
return if Prism::BACKEND == :FFI
6-
75
module Prism
86
class IntegerParseTest < TestCase
97
def test_integer_parse
@@ -37,9 +35,7 @@ def test_integer_parse
3735
private
3836

3937
def assert_integer_parse(expected, source = expected.to_s)
40-
integer, string = Debug.integer_parse(source)
41-
assert_equal expected, integer
42-
assert_equal expected.to_s, string
38+
assert_equal expected, Prism.parse(source).value.statements.body.first.value
4339
end
4440
end
4541
end

0 commit comments

Comments
 (0)