Reverse-sync numbered reference range handling

Author: kddnewton

src/prism.c

@@ -6151,14 +6151,14 @@ pm_numbered_reference_read_node_number(pm_parser_t *parser, const pm_token_t *to
     errno = 0;
     unsigned long value = strtoul(digits, &endptr, 10);
 
-    if ((digits == endptr) || (*endptr != '\0') || (errno == ERANGE)) {
+    if ((digits == endptr) || (*endptr != '\0')) {
         pm_parser_err(parser, start, end, PM_ERR_INVALID_NUMBER_DECIMAL);
         value = 0;
     }
 
     xfree(digits);
 
-    if (value > NTH_REF_MAX) {
+    if ((errno == ERANGE) || (value > NTH_REF_MAX)) {
         PM_PARSER_WARN_FORMAT(parser, start, end, PM_WARN_INVALID_NUMBERED_REFERENCE, (int) (length + 1), (const char *) token->start);
         value = 0;
     }

test/prism/result/warnings_test.rb

@@ -174,6 +174,10 @@ def test_keyword_eol
       assert_warning("if true\nelsif\nfalse; end", "end of line")
     end
 
+    def test_numbered_reference
+      assert_warning("_ = _ = $999999999999999999999", "too big for a number variable, always nil")
+    end
+
     def test_shareable_constant_value
       assert_warning("foo # shareable_constant_value: none", "ignored")
       assert_warning("\v  # shareable_constant_value: none", "ignored")