Translation::Parser should process warnings, not just errors

Author: noahgibbs

lib/prism/translation/parser.rb

@@ -17,9 +17,9 @@ class Diagnostic < ::Parser::Diagnostic
         attr_reader :message
 
         # Initialize a new diagnostic with the given message and location.
-        def initialize(message, location)
+        def initialize(message, level, location)
           @message = message
-          super(:error, :prism_error, {}, location, [])
+          super(level, :prism_error, {}, location, [])
         end
       end
 
@@ -113,7 +113,13 @@ def unwrap(result, offset_cache)
           next unless valid_error?(error)
 
           location = build_range(error.location, offset_cache)
-          diagnostics.process(Diagnostic.new(error.message, location))
+          diagnostics.process(Diagnostic.new(error.message, :error, location))
+        end
+        result.warnings.each do |warning|
+          next unless valid_error?(warning)
+
+          location = build_range(warning.location, offset_cache)
+          diagnostics.process(Diagnostic.new(warning.message, :warning, location))
         end
 
         result

test/prism/parser_test.rb

@@ -94,6 +94,19 @@ class ParserTest < TestCase
       end
     end
 
+    def test_warnings
+      buffer = Parser::Source::Buffer.new("inline ruby with warning", 1)
+      buffer.source = "do_something *array"
+
+      parser = Prism::Translation::Parser.new
+      parser.diagnostics.all_errors_are_fatal = false
+      warning = nil
+      parser.diagnostics.consumer = ->(received) { warning = received }
+      parser.parse(buffer)
+      assert_equal :warning, warning.level
+      assert_includes warning.message, "has been interpreted as"
+    end
+
     private
 
     def assert_equal_parses(filepath, compare_tokens: true)