Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prism accepts foo[1]{ 2 } += 1 #1927

Closed
makenowjust opened this issue Nov 26, 2023 · 0 comments · Fixed by #1928
Closed

Prism accepts foo[1]{ 2 } += 1 #1927

makenowjust opened this issue Nov 26, 2023 · 0 comments · Fixed by #1928

Comments

@makenowjust
Copy link
Contributor

makenowjust commented Nov 26, 2023 •
edited
Loading

CRuby rejects foo[1]{ 2 } += 1, but Prism accepts it.

Related PRs/issues: #1636, #1925
makenowjust added a commit to makenowjust/prism-1 that referenced this issue Nov 26, 2023
@makenowjust
Fix and reuse pm_call_node_index_p
28c1782 
Fix ruby#1925
Fix ruby#1927

Previously pm_call_node_index_p does not check about a block argument
correctly and is not used in parse_write to check an index call node.

This issue fixes these problems.
makenowjust added a commit to makenowjust/prism-1 that referenced this issue Nov 26, 2023
@makenowjust
Fix and reuse pm_call_node_index_p
277148e 
Fix ruby#1925
Fix ruby#1927

Previously pm_call_node_index_p does not check about a block argument
correctly and is not used in parse_write to check an index call node.

This commit fixes these problems.
@makenowjust makenowjust mentioned this issue Nov 26, 2023
Merged
kddnewton pushed a commit that referenced this issue Nov 27, 2023
@makenowjust @kddnewton
Fix and reuse pm_call_node_index_p
92bab04 
Fix #1925
Fix #1927

Previously pm_call_node_index_p does not check about a block argument
correctly and is not used in parse_write to check an index call node.

This commit fixes these problems.
matzbot pushed a commit to ruby/ruby that referenced this issue Nov 27, 2023
@makenowjust @matzbot
[ruby/prism] Fix and reuse pm_call_node_index_p
8654859 
Fix ruby/prism#1925
Fix ruby/prism#1927

Previously pm_call_node_index_p does not check about a block argument
correctly and is not used in parse_write to check an index call node.

This commit fixes these problems.

ruby/prism@92bab044ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and reuse pm_call_node_index_p makenowjust/prism-1
1 participant
@makenowjust