Use version: 3.3.1 against Translation::Parser
#2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
use_3_3_3_against_translation_parser
branch
from
52ef5cf
to
20c1903
Compare
Follow up ruby#2760. This PR updates the `Translation::Parser` to use version 3.3.1 when the version 3.3 is specified. The Parser gem is structured to support the latest patch versions, hence this aligns with Parser-compatible versioning. As noted in ruby#2760, the behavior remains unchanged with this switch from 3.3.0 to 3.3.1.
koic
force-pushed
the
use_3_3_3_against_translation_parser
branch
from
20c1903
to
efde09d
Compare
kddnewton
approved these changes
May 4, 2024
ParadoxV5
added a commit
to ParadoxV5/prism
that referenced
this pull request
May 25, 2024
As observed in ruby#2771, `?=` thinks that implicit definitions of CC`, `AR` and `ARFLAGS` are explicit. Disabling implicit variables is more straightforward than adapting the `Makefile` and `extconf.rb` around them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #2760.
This PR updates the
Translation::Parserto use version 3.3.1 when the version 3.3 is specified. The Parser gem is structured to support the latest patch versions, hence this aligns with Parser-compatible versioning. As noted in #2760, the behavior remains unchanged with this switch from 3.3.0 to 3.3.1.