Document ForNode fields
#2845
Merged
Document ForNode fields
#2845
+38
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b23a05a.
kddnewton
requested changes
May 28, 2024
config.yml
Outdated
| @@ -1880,19 +1880,55 @@ nodes: | |||
| fields: | |||
| - name: index | |||
| type: node | |||
| comment: | | |||
| The index variable for `for` loops. | |||
There was a problem hiding this comment.
Suggested change
| The index variable for `for` loops. | |
| The index expression for `for` loops. |
This can be quite a few different kinds of expressions. This includes for foo, but also for foo, bar, baz, for @foo, for $foo, etc. Could you put a little more into this message explaining that?
|
Great! Last thing is can you rebase? |
…document_for_fields
|
I have rebased. #2845 (comment) |
kddnewton
approved these changes
May 29, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 29, 2024
(ruby/prism#2845) * Add document * fix * fix fmt * fix fmt * Revert "fix fmt" This reverts commit ruby/prism@b23a05a94148. * add potition * fix fmt * reposition * fix indent * fix comment * fix indent ruby/prism@0dd4c1bba1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #2123