Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use partial_script for the parser translators #3130

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Use partial_script for the parser translators #3130

merged 2 commits into from
Oct 3, 2024

Conversation

Earlopain
Copy link
Contributor

Followup to #3079

@Earlopain Earlopain mentioned this pull request Oct 3, 2024
Merged
8 tasks
@Earlopain
Copy link
Contributor Author

Earlopain commented Oct 3, 2024 •
edited
Loading

I just noticed typecheck failures. Seems like that option is missing from prism.rbi. Should I add it in this PR?

Edit: Went ahead and added it

@kddnewton kddnewton merged commit 9f4b24d into ruby:main Oct 3, 2024
54 checks passed
@Earlopain Earlopain deleted the parser-translator-partial_script branch October 3, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kddnewton kddnewton kddnewton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Earlopain @kddnewton