Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve YAMLTree performance by not using object_ids #663

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Improve YAMLTree performance by not using object_ids #663

merged 2 commits into from
Dec 18, 2023

Commits on Dec 18, 2023

  1. Use compare_by_identity instead of object_id 

    Object IDs became more expensive in Ruby 2.7. Using `Hash#compare_by_identity` let's us get the same effect, without needing to force all these objects to have object_ids assigned to them.
    @amomchilov
    amomchilov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    df69e4a View commit details
    Browse the repository at this point in the history

  2. Use assert_same in tests where applicable

    @amomchilov
    amomchilov committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    0dc25a9 View commit details
    Browse the repository at this point in the history