Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused array #665

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Remove unused array #665

merged 2 commits into from
Dec 19, 2023

Conversation

amomchilov
Copy link
Contributor

I noticed in #663 that the @targets ivar in Psych::YAMLTree::Registrar is only ever written into, and never read.

Comment on lines -31 to -32
rescue NoMethodError
false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this in #663.

I believe it existed to just catch if object_id was not defined, but since we don't call that anymore, we don't have to worry about it being missing.

@tenderlove
Copy link
Member

Excellent! Thank you!

@tenderlove tenderlove merged commit 52b4780 into ruby:master Dec 19, 2023
60 checks passed
@amomchilov amomchilov deleted the remove-unused-array branch September 2, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants