Removed needless requires #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hsbt
commented
May 6, 2016
hsbt
commented
- shellwords is not use in Rake 11
- thread is already core library. Not necessary for using it
* shellwords didn't use Rake 11 * thread is core library
wmfgerrit
pushed a commit
to wikimedia/mediawiki-selenium
that referenced
this pull request
Dec 19, 2016
…ellwords Rake used to require Shellwords, but since v11.2.0 no longer does so. For more information see ruby/rake#131 Bug: T153202 Change-Id: I2f741e62654a8ef9e6b84f591cc4b0f164e465f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.