Fix Rake.verbose to return true/false even if unset #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unset returns FileUtilsExt.verbose_flag which is set to Object.new by default, which is truthy. Compare against DEFAULT and return verbose_flag only if set.
zenspider
added a commit
to minitest/minitest
that referenced
this pull request
May 11, 2024
…, but until then, compare against true. [git-p4: depot-paths = "//src/minitest/dev/": change = 14139]
|
@hsbt comment pls? |
hsbt
reviewed
Jun 18, 2024
| @@ -105,6 +105,8 @@ def test_safe_ln_fails_on_script_error | |||
| end | |||
|
|
|||
| def test_verbose | |||
| RakeFileUtils.verbose_flag = Rake::FileUtilsExt::DEFAULT | |||
There was a problem hiding this comment.
Is it necessary? In my understanding, your change is for without above line.
|
Additionally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unset returns FileUtilsExt.verbose_flag which is set to Object.new by default, which is truthy. Compare against DEFAULT and return verbose_flag only if set.
This is made extra confusing by the fact that this project uses its own TestTask which sets verbose outside of the test run... so this extends the verbose test by setting it back to DEFAULT.