Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version.rb - update from 3.2.0 to 3.2.2 #1579

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

MSP-Greg
Copy link
Contributor

This is causing the RBS gem to not be installed in Ruby master. I believe gems/bundled_gems in ruby/ruby will also need an update...

@MSP-Greg
Copy link
Contributor Author

Windows ruby-loco builds and a local Ubuntu build log the following:

installing bundled gems:            /usr/local/lib/ruby/gems/3.3.0+0
                                    minitest 5.20.0
                                    power_assert 2.0.3
                                    rake 13.0.6
                                    test-unit 3.6.1
                                    rexml 3.2.6
                                    rss 0.3.0
                                    net-ftp 0.2.0
                                    net-imap 0.4.1
                                    net-pop 0.1.2
                                    net-smtp 0.4.0
                                    matrix 0.4.2
                                    prime 0.1.2
                                    typeprof 0.21.8
                                    debug 1.8.0
                                    racc 1.7.1
installing bundled gem cache:       /usr/local/lib/ruby/gems/3.3.0+0/cache
skipped bundled gems:
    rbs-3.2.0.gem                   not found in bundled_gems

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇‍♂️

@soutaro soutaro added this pull request to the merge queue Oct 30, 2023
Merged via the queue into ruby:master with commit f47e4b8 Oct 30, 2023
23 checks passed
@ksss
Copy link
Collaborator

ksss commented Oct 30, 2023

@MSP-Greg
@soutaro

Shouldn't we have made it 3.3.0 that the next release version?

When installing the master branch locally, I believe it can be confusing to determine whether 3.2.2 is the local version or the released version of 3.2.2.

From my understanding, RBS branches just like CRuby.
How about setting the version of the master branch to the next release miner version?
This way, when we install the master branch locally, we won't confuse it with the released version of 3.2.2.

@MSP-Greg
Copy link
Contributor Author

@ksss

Agree. I probably should have mentioned that. Not being sure whether the next release would be a patch or minor change, I left it as the most recent release. I think ruby/openssl uses a .dev minor release in master (?).

When installing the master branch locally

I didn't want to see 3.2.0, which is really confusing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants