Skip to content

Commit d096222

Browse files
committed
Prefer require 'cgi/util' instead of require 'cgi'
RDoc is using only CGI.escape, escapeHTML, and unescape. We don't have to load the whole source code of cgi gem.
1 parent a93e1bc commit d096222

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

lib/rdoc/context.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
# frozen_string_literal: true
2-
require 'cgi'
3-
42
##
53
# A Context is something that can hold modules, classes, methods, attributes,
64
# aliases, requires, and includes. Classes, modules, and files are all

lib/rdoc/context/section.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
# frozen_string_literal: true
2+
require 'cgi/util'
3+
24
##
35
# A section of documentation like:
46
#

lib/rdoc/markup/to_html.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# frozen_string_literal: true
2-
require 'cgi'
2+
require 'cgi/util'
33

44
##
55
# Outputs RDoc markup as HTML.

lib/rdoc/markup/to_label.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# frozen_string_literal: true
2-
require 'cgi'
2+
require 'cgi/util'
33

44
##
55
# Creates HTML-safe labels suitable for use in id attributes. Tidylinks are

lib/rdoc/method_attr.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ def block_params=(value)
289289
# HTML id-friendly method/attribute name
290290

291291
def html_name
292-
require 'cgi'
292+
require 'cgi/util'
293293

294294
CGI.escape(@name.gsub('-', '-2D')).gsub('%','-').sub(/^-/, '')
295295
end

0 commit comments

Comments
 (0)