-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] New file RI.md #1100
[DOC] New file RI.md #1100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this document to be very wordy and repetitive. I have a few concerns:
- Who is this targeted towards? Users of
ri
want a quick reference and are probably using theri -h
or theman ri
documentation. - There are many repeated parts in this documentation. The "Class and Module Documents" section on line 326 is pretty similar to the "Ruby Class and Module Documents" section on 572. The documentation for static and interactive are very similar and are repeats of one another.
I'm thinking more of the new user (possibly the never-before-user). This content will need to be someplace where both the user and the search engines will find it. An eventual aim is to show (in -h and --help) ri commands that will fetch relevant documentation. I'd never heard of |
Some of the repetition arises from my misunderstanding about how many things are here. I'd thought four (class/page ruby/gem), but it may be more useful to think of two (class/page only). All classes (including gem classes) are already available in the class list; if we think of I'll look into how to avoid repetition between static/interactive. |
I'm not sure what you mean by "actual source (not derived)". The source is in the file /man/ri.1. I think it's better to improve the man page rather than this document since man pages are the de facto way of reading the documentation for commands in Linux. I'm not sure that it's out-of-date because the ri command hasn't really changed in the past few years. |
Just meant source text -- not derived from something else; e.g., .{html|ri} derived from .{c|rb|rdoc|md}.
I'm willing to work with the man page later on. This page RI.md (though it still needs major work) is for everyone, not just for those on Linux. |
Much more work to be done here, so marking as Draft and removing review requests. |
I have converted the links to markdown-style reference links:
I've experimented, and have found various forms that work on one or the other, but not on both. |
@colby-swandalem, any ideas about this? |
I'm a bit lost sorry, if having URLs works for both renders of the document, then that's a good thing right? What issues are there going this route? |
@colby-swandale, do you mean the route of all-URL, no rdoc-ref? Would work for both, but:
Alternatively, RDoc could in its RI output convert rdoc-refs to URLs? Out-of-scope for me, but possibly interesting. |
In general, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small nitpicks, but i think overall this is nearly ready!
| ri Nokogiri | Document for gem module Nokogiri. | | ||
<br> | ||
|
||
If [option \\--all][4] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the use of \
necessary here as it's hard to tell what it's for? Should we perhaps be wrapping these in code blocks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This idiom is what I found that keeps the double-hyphen from converting to a dash. Also, if in code block, the token would not link, which I think matters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see how the community reacts to this. If it's clear what the intention is, than great. Otherwise we will probably need to review the use of these.
<br> | ||
|
||
There are more lists available; | ||
see [option \\--list][8]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look similar to to https://github.com/ruby/rdoc/pull/1100/files#r1618865177
(by @colby-swandale)
Is the use of
\
necessary here as it's hard to tell what it's for? Should we perhaps be wrapping these in code blocks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as there. Stet, I think.
[6]: rdoc-ref:RI.md@Page+Documents | ||
[7]: rdoc-ref:RI.md@ri+Lists | ||
[8]: rdoc-ref:RI.md@Options+--list-2C+-l-2C+--no-list | ||
[9]: https://docs.ruby-lang.org/en/master/IRB.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IRB now has its own dedicated doc site, let's use it:
[9]: https://docs.ruby-lang.org/en/master/IRB.html | |
[9]: https://ruby.github.io/irb/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree. I'm writing for Ruby, and prefer to stay on its site when practicable.
@BurdetteLamar 👋🏻 myself and @st0012 now have commit access to RDoc with the aim of becoming maintainers. I think we will be happy to merge this once the last of the feedback has been addressed. Let me know if you have any questions! |
Thanks, @colby-swandale. I'll try to sort out what's unaddressed. (Won't be easy, with conversation of 77 parts!) |
@colby-swandale and @st0012: anything more needed here? |
Can I get a review, an approval, or a merge here? (At this point, I'd almost settle for a close.) |
I apologise for the wait @BurdetteLamar, but I hope you can understand that we are busy with our lives and can only volunteer so much of our time. |
Replaces the very spare
RI.rdoc
with the robustRI.md
.This is meant for new or less-experienced RI users (who may have found this page in a browser search).