Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] New file RI.md #1100

Merged
merged 27 commits into from
Jul 3, 2024
Merged

[DOC] New file RI.md #1100

merged 27 commits into from
Jul 3, 2024

Conversation

BurdetteLamar
Copy link
Member

@BurdetteLamar BurdetteLamar commented Mar 22, 2024

Replaces the very spare RI.rdoc with the robust RI.md.

This is meant for new or less-experienced RI users (who may have found this page in a browser search).

Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this document to be very wordy and repetitive. I have a few concerns:

  1. Who is this targeted towards? Users of ri want a quick reference and are probably using the ri -h or the man ri documentation.
  2. There are many repeated parts in this documentation. The "Class and Module Documents" section on line 326 is pretty similar to the "Ruby Class and Module Documents" section on 572. The documentation for static and interactive are very similar and are repeats of one another.

RI.md Outdated Show resolved Hide resolved
RI.md Outdated Show resolved Hide resolved
RI.md Outdated Show resolved Hide resolved
RI.md Outdated Show resolved Hide resolved
RI.md Outdated Show resolved Hide resolved
@BurdetteLamar
Copy link
Member Author

1. Who is this targeted towards? Users of `ri` want a quick reference and are probably using the `ri -h` or the `man ri` documentation.

I'm thinking more of the new user (possibly the never-before-user). This content will need to be someplace where both the user and the search engines will find it.

An eventual aim is to show (in -h and --help) ri commands that will fetch relevant documentation.

I'd never heard of man ri. It's very old (and no doubt out-of-date). Seems to be actual source (not derived); is that right? I find that it's available on my Linux machine, but not on Windows; don't know about elsewhere.

@BurdetteLamar
Copy link
Member Author

2. There are many repeated parts in this documentation. The "Class and Module Documents" section on line 326 is pretty similar to the "Ruby Class and Module Documents" section on 572. The documentation for static and interactive are very similar and are repeats of one another.

Some of the repetition arises from my misunderstanding about how many things are here. I'd thought four (class/page ruby/gem), but it may be more useful to think of two (class/page only). All classes (including gem classes) are already available in the class list; if we think of ruby: is a pseudo-gem, all pages are of one kind.

I'll look into how to avoid repetition between static/interactive.

@peterzhu2118
Copy link
Member

I'd never heard of man ri. It's very old (and no doubt out-of-date). Seems to be actual source (not derived); is that right? I find that it's available on my Linux machine, but not on Windows; don't know about elsewhere.

I'm not sure what you mean by "actual source (not derived)". The source is in the file /man/ri.1. I think it's better to improve the man page rather than this document since man pages are the de facto way of reading the documentation for commands in Linux.

I'm not sure that it's out-of-date because the ri command hasn't really changed in the past few years.

@BurdetteLamar
Copy link
Member Author

I'm not sure what you mean by "actual source (not derived)". The source is in the file /man/ri.1.

Just meant source text -- not derived from something else; e.g., .{html|ri} derived from .{c|rb|rdoc|md}.

I think it's better to improve the man page rather than this document since man pages are the de facto way of reading the documentation for commands in Linux.

I'm willing to work with the man page later on. This page RI.md (though it still needs major work) is for everyone, not just for those on Linux.

@BurdetteLamar
Copy link
Member Author

Much more work to be done here, so marking as Draft and removing review requests.

@BurdetteLamar BurdetteLamar marked this pull request as draft April 1, 2024 16:44
@BurdetteLamar BurdetteLamar requested review from peterzhu2118 and removed request for olleolleolle, drbrain, hsbt and peterzhu2118 April 1, 2024 16:44
@BurdetteLamar
Copy link
Member Author

I have converted the links to markdown-style reference links:

  • Those that have URLs work fine, both in the HTML and on the GitHub page.
  • Those that have rdoc-ref work in the HTML, but not on the GitHub page.

I've experimented, and have found various forms that work on one or the other, but not on both.
Any hints, anyone?

@BurdetteLamar
Copy link
Member Author

I have converted the links to markdown-style reference links:

* Those that have URLs work fine, both in the HTML and on the GitHub page.

* Those that have `rdoc-ref` work in the HTML, but not on the GitHub page.

I've experimented, and have found various forms that work on one or the other, but not on both. Any hints, anyone?

@colby-swandalem, any ideas about this?

@colby-swandale
Copy link
Member

I have converted the links to markdown-style reference links:

  • Those that have URLs work fine, both in the HTML and on the GitHub page.
  • Those that have rdoc-ref work in the HTML, but not on the GitHub page.

I've experimented, and have found various forms that work on one or the other, but not on both. Any hints, anyone?

I'm a bit lost sorry, if having URLs works for both renders of the document, then that's a good thing right? What issues are there going this route?

@BurdetteLamar
Copy link
Member Author

BurdetteLamar commented May 10, 2024

I have converted the links to markdown-style reference links:

  • Those that have URLs work fine, both in the HTML and on the GitHub page.
  • Those that have rdoc-ref work in the HTML, but not on the GitHub page.

I've experimented, and have found various forms that work on one or the other, but not on both. Any hints, anyone?

I'm a bit lost sorry, if having URLs works for both renders of the document, then that's a good thing right? What issues are there going this route?

@colby-swandale, do you mean the route of all-URL, no rdoc-ref? Would work for both, but:

  • At a minimum would need to be added to the Documentation Guide; thoughts from the Guide guide @jeremyevans?

  • At a maximum, would need to be put up as an issue for the dev meeting.

Alternatively, RDoc could in its RI output convert rdoc-refs to URLs? Out-of-scope for me, but possibly interesting.

@jeremyevans
Copy link
Contributor

In general, rdoc-ref is useful because it makes the references internally consistent. If all references are to URLs, then there is no need for rdoc-ref, but if you are referencing something else in the documentation currently being generated, you want to use rdoc-ref as opposed to URLs. It's a shame GitHub doesn't handle rdoc-ref, but that's a GitHub issue, and I don't think we should avoid rdoc-ref just because GitHub doesn't render it correctly. The goal should be something that works best with rdoc/ri generated documentation.

@BurdetteLamar BurdetteLamar marked this pull request as ready for review May 16, 2024 17:34
@BurdetteLamar
Copy link
Member Author

Maintainers @drbrain and @hsbt, this won't be merged without your blessing, or one from someone you designate. Can we proceed here?

Copy link
Member

@colby-swandale colby-swandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nitpicks, but i think overall this is nearly ready!

RI.md Outdated Show resolved Hide resolved
| ri Nokogiri | Document for gem module Nokogiri. |
<br>

If [option \\--all][4]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the use of \ necessary here as it's hard to tell what it's for? Should we perhaps be wrapping these in code blocks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This idiom is what I found that keeps the double-hyphen from converting to a dash. Also, if in code block, the token would not link, which I think matters.

Copy link
Member

@colby-swandale colby-swandale Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how the community reacts to this. If it's clear what the intention is, than great. Otherwise we will probably need to review the use of these.

RI.md Outdated Show resolved Hide resolved
RI.md Outdated Show resolved Hide resolved
<br>

There are more lists available;
see [option \\--list][8].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look similar to to https://github.com/ruby/rdoc/pull/1100/files#r1618865177

(by @colby-swandale)

Is the use of \ necessary here as it's hard to tell what it's for? Should we perhaps be wrapping these in code blocks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as there. Stet, I think.

RI.md Outdated Show resolved Hide resolved
[6]: rdoc-ref:RI.md@Page+Documents
[7]: rdoc-ref:RI.md@ri+Lists
[8]: rdoc-ref:RI.md@Options+--list-2C+-l-2C+--no-list
[9]: https://docs.ruby-lang.org/en/master/IRB.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IRB now has its own dedicated doc site, let's use it:

Suggested change
[9]: https://docs.ruby-lang.org/en/master/IRB.html
[9]: https://ruby.github.io/irb/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree. I'm writing for Ruby, and prefer to stay on its site when practicable.

RI.md Outdated Show resolved Hide resolved
@BurdetteLamar
Copy link
Member Author

Maintainers @hsbt and @nobu: any comments on this PR?

@colby-swandale
Copy link
Member

@BurdetteLamar 👋🏻 myself and @st0012 now have commit access to RDoc with the aim of becoming maintainers. I think we will be happy to merge this once the last of the feedback has been addressed.

Let me know if you have any questions!

@BurdetteLamar
Copy link
Member Author

@BurdetteLamar 👋🏻 myself and @st0012 now have commit access to RDoc with the aim of becoming maintainers. I think we will be happy to merge this once the last of the feedback has been addressed.

Let me know if you have any questions!

Thanks, @colby-swandale. I'll try to sort out what's unaddressed. (Won't be easy, with conversation of 77 parts!)

@BurdetteLamar
Copy link
Member Author

@colby-swandale and @st0012: anything more needed here?

@BurdetteLamar
Copy link
Member Author

BurdetteLamar commented Jul 1, 2024

Can I get a review, an approval, or a merge here? (At this point, I'd almost settle for a close.)

@colby-swandale
Copy link
Member

I apologise for the wait @BurdetteLamar, but I hope you can understand that we are busy with our lives and can only volunteer so much of our time.

@peterzhu2118 peterzhu2118 merged commit d7bca12 into ruby:master Jul 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants