Ensure no escape sequence before printing prompt #716
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test (readline-ext, bundler) expects output of
Readline.readline("prompt>")
to match/\Aprompt>/
.Readline prints
"\e[?2004h"
(enable bracketed-paste) before prompt if STDIN and STDOUT is both tty.Readline does not print escape sequence before prompt if STDIN or STDOUT is not a tty. But Reline prints it.
This pull request fixes Reline to align with Readline.
Background
Ruby ci was failing. https://github.com/ruby/ruby/actions/runs/9352049059/job/25739247917
This pull request fixes the problem of Reline side. Unfortunately, test still fails. I'll also open a pull request to Rubygems to relax the test assertion.