Could you set required_ruby_version >= 2.1? Latest 3.2.5 release is broken on Ruby 2.0 #69
Comments
|
@ivoanjo Would you like to offer a PR with that change? |
|
Sure, I'll whip up a PR in a few minutes! |
ivoanjo
added a commit
to DataDog/rexml
that referenced
this issue
Apr 6, 2021
Ruby 2.3 is the oldest Ruby that still passes all tests when running `rake test`. By setting it in the `gemfile`, we ensure that older Ruby versions don't try to use an incompatible `rexml` version. (Note: It's probably trivial to support the older Rubies, but I'll leave that for someone who is interested enough in doing the extra work) Issue ruby#69
|
PR opened #70 . Would be really nice if this could get released quickly! (Would save me from having to hack a workaround on our CI 😭 ) |
ivoanjo
added a commit
to DataDog/rexml
that referenced
this issue
Apr 9, 2021
Ruby 2.6 is the oldest Ruby that's hasn't reached EOL. By setting it in the `gemspec`, we ensure that older Ruby versions don't try to use an incompatible `rexml` version. Issue ruby#69
ivoanjo
added a commit
to DataDog/rexml
that referenced
this issue
Apr 9, 2021
Ruby 2.6 is the oldest Ruby that hasn't reached EOL. By setting it in the `gemspec`, we ensure that older Ruby versions don't try to use an incompatible `rexml` version. Issue ruby#69
ivoanjo
added a commit
to DataDog/rexml
that referenced
this issue
Apr 9, 2021
This gem is no longer tested with Rubies older than 2.5, and it's actually broken on at least <= 2.2. By setting the minimum version in the `gemspec`, we ensure that older Ruby versions don't try to use an incompatible `rexml` version. Issue ruby#69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello there!
I'm one of the maintainers for @DataDog's ddtrace gem. We still support customers running Ruby 2.0, and run our CI with Ruby 2.0 as well.
We've noticed that the latest 3.2.5 release no longer works on Ruby 2.0. Of course, it doesn't make any sense to ask upstream to still support Ruby 2.0 (good riddance), but I'd like to ask for two things:
required_ruby_version = '>=2.1'(or some later version) to the gemspec and release a 3.2.6 with that change?Thanks a lot, and let me know if there's anything I can help with to make this move faster :)
The text was updated successfully, but these errors were encountered: