itunes: support lowercased episodeType values #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozydingo
commented
Jun 26, 2024
| @@ -593,7 +593,7 @@ def itunes_episode_type_writer(name, disp_name=name) | |||
| module_eval(<<-DEF, *get_file_and_line_from_caller(2)) | |||
| def #{name}=(new_value) | |||
| if @do_validate and | |||
| !["Full", "Trailer", "Bonus", nil].include?(new_value) | |||
| !["Full", "full", "Trailer", "trailer", "Bonus", "bonus", nil].include?(new_value) | |||
There was a problem hiding this comment.
@kou note here your comment from the original PR is addressed
kou
reviewed
Jun 26, 2024
.github/workflows/test.yml
Outdated
There was a problem hiding this comment.
Could you rebase on master to remove unrelated changes?
There was a problem hiding this comment.
Yep, sorry that I didn't notice that! Done.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forking #48 to address @kou's comment as the original author (@liberlanco) has not responded.
Fixes #51 (comment)
Context from #48: