Add rubocop-rubycw #113
Merged
Add rubocop-rubycw #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanachin
force-pushed
the
add_rubocop-rubycw
branch
from
a5acd2f to
f22c25c
Compare
pocke
reviewed
Dec 14, 2019
Rakefile
Outdated
| end | ||
|
|
||
| task :rubocop do | ||
| sh "rubocop -P" |
There was a problem hiding this comment.
Personally I prefer the long option, --parallel, to -P in a committed file.
Because it is explicit.
I also like the short option on a console, because it needs fewer types.
But typing count is not important in a committed file. Readable code is more important.
There was a problem hiding this comment.
Totally! I updated the option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to ensure no warning, such as:
https://github.com/ruby/ruby-signature/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aclosed+warning