Skip to content

Revise CONTRIBUTING.md #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

Revise CONTRIBUTING.md #183

merged 1 commit into from
Jan 9, 2020

Conversation

pocke
Copy link
Member

@pocke pocke commented Jan 8, 2020

This pull request fixes three problems in CONTRIBUTING.md

  • FIx the option name, it was --merged but it should be --merge.
  • Add file path or class name to the command examples.
    • Because I was confused by the command without the target. I tried some argument candidates until I found the right argument.
  • Fix typos. "Commiting" to "Committing", and "contributers" to "contributors".

soutaro
soutaro approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️

@soutaro soutaro merged commit 88e1bf1 into ruby:master Jan 9, 2020
@pocke pocke deleted the contributing.md branch January 9, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soutaro soutaro soutaro approved these changes

+1 more reviewer

@hanachin hanachin hanachin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pocke @soutaro @hanachin