Skip to content

Update Symbol signatures #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Jan 17, 2020
Merged

Update Symbol signatures #184

merged 35 commits into from
Jan 17, 2020

Conversation

hanachin
Copy link
Contributor

@hanachin hanachin commented Jan 8, 2020

No description provided.

@hanachin hanachin marked this pull request as ready for review January 10, 2020 18:14
@hanachin
Copy link
Contributor Author

Now it's ready for review.

soutaro
soutaro reviewed Jan 11, 2020
View reviewed changes
.rubocop.yml
require: rubocop-rubycw
AllCops:
TargetRubyVersion: 2.6
TargetRubyVersion: 2.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

soutaro
soutaro reviewed Jan 11, 2020
View reviewed changes
soutaro
soutaro reviewed Jan 11, 2020
View reviewed changes
soutaro
soutaro requested changes Jan 11, 2020
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small fixes, please. 🙇

hanachin
hanachin commented Jan 13, 2020
View reviewed changes
Copy link
Contributor Author

@hanachin hanachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late response. I fixed them all.

soutaro
soutaro approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔣

@soutaro soutaro merged commit 0119640 into ruby:master Jan 17, 2020
@hanachin hanachin deleted the update_symbol branch January 17, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soutaro soutaro soutaro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hanachin @soutaro