Add JSON #279
Merged
Add JSON #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
reviewed
May 4, 2020
| spec.add_development_dependency "rubocop" | ||
| spec.add_development_dependency "rubocop-rubycw" | ||
| spec.add_development_dependency "minitest-reporters", "~> 1.3.6" | ||
| spec.add_development_dependency "json", "~> 2.3.0" |
There was a problem hiding this comment.
Okay, JSON is a gem... I think the best way is to put RBS in JSON gem, but I think it's okay to have the signatures here for now.
soutaro
reviewed
May 4, 2020
| type real = Integer | Float | Rational | ||
|
|
||
| type string = String | _ToStr | ||
| type encoding = Encoding | string |
soutaro
reviewed
May 4, 2020
stdlib/json/json.rbs
Outdated
|
|
||
| alias self.fast_unparse self.fast_generate | ||
|
|
||
| def self.generate: (_ToJson obj, ?json_options opts) -> String |
There was a problem hiding this comment.
Could you rewrite these module functions using def self?.generate: ... syntax?
There was a problem hiding this comment.
Thanks for the review! I updated the signature to use the def self?. syntax.
soutaro
approved these changes
May 6, 2020
|
@soutaro Done ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.