Improve same directory detection in FileUtils #1425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkn
pushed a commit
to mrkn/ruby
that referenced
this pull request
Dec 1, 2017
….local" address. ruby#1425 Patch by @elct9620 [fix rubyGH-1484] git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@60275 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt
pushed a commit
to ruby/fileutils
that referenced
this pull request
Aug 6, 2019
hsbt
added a commit
to ruby/resolv
that referenced
this pull request
May 22, 2020
….local" address. ruby/ruby#1425 Patch by @elct9620 [fix GH-1484] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60275 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileUtils.cp_rdoes not detect copying a directory to itself if either the source or destination contains a dot (.). Depending on order and platform, this can cause different errors likeFile name too longorunknown file typeor just stack overflow.This patch changes the current dynamic regex approach to comparing absolute paths.
The test commands in the Travis CI config did not show test failure for me, but
make test-all TESTOPTS="-q -- test/fileutils/test_fileutils.rb"with the new tests but without the changes todescendant_directory?shows the failure clearly.Example of not detecting same directory:
Click for example