Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yarn.lock, remove Windows mswin ssl cert related code #482

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

MSP-Greg
Copy link
Collaborator

@MSP-Greg MSP-Greg commented Mar 15, 2023

  1. MSYS2 recently changed the folder that the ssl cert file is located in. 'Git for Windows' is built with MSYS2. The most recent version has the files in etc/ssl, older versions have them in ssl. Code now looks in both locations. This file is needed for Windows Rubies 2.3 and earlier, as they don't include a cert file, and the code uses the cert file included with 'Git for Windows'...

  2. The ruby-loco mswin build now has a bundled cert file. Removed the code for that.

  3. Updated yarn.lock.

Note that the Actions images that are currently rolling out will not work without this PR. Sorry, I forgot about the 'Git for Windows' change due to the MSYS2 change...

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit e6689b4 into ruby:master Mar 16, 2023
@MSP-Greg MSP-Greg deleted the 00-mswin-ssl-cert branch March 17, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants