-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock @actions/cache to 3.0.6, later versions break bundler caching #484
Conversation
Two jobs have 429 errors? That's 'Too Many Requests'? What else is going to happen today??? See: |
I did some more testing, and it seems that 3.1.0 and 3.1.1 also seem to work. 3.1.2 and later do not. Also, see: |
Thanks for addressing this @MSP-Greg. Would it be enough to restart failing checks for now, 🙏 merge and release? |
My thoughts is we should avoid "blindly" updating to latest versions of dependencies without a need, things tend to break, it's not the first time. Thank you for the PR. |
Given that the change in I'll see if we can add some testing to caching to verify that it works correctly. That may be difficult, given that there may be CDN delays, not sure. JFYI, this weekend I changed the code in |
yarn.lock
Outdated
version "4.0.0" | ||
resolved "https://registry.yarnpkg.com/yallist/-/yallist-4.0.0.tgz#9bb92790d9c0effec63be73519e11a35019a3a72" | ||
integrity sha512-3wdGidZyq5PB084XLES5TpOSRA3wjXAlIWMhum2kRcv/41Sn2emQ0dycQW4uZXLejwKvg6EsvbdlVL+FYEct7A== | ||
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has CRLF that's why the diff is so big, I'll regenerate it with LF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry & thanks. I thought I've got Git set up so that can't happen. Maybe a new version. I'll check. But, that file is CLI generated, and my editor is always 'LF' only.
Maybe we can do that by using ruby/setup-ruby twice in in the same workflow job, and having some debug env var or so to fail if the cache isn't restored in the 2nd usage. |
Yes, I thought something similar. I'm back to testing this because I'm just a little frustrated by it... |
See #483. I can't look at it until (hopefully) this weekend.
It may be a bug with @actions/cache, as I tried both 3.1.4 & 3.2.1. Not.sure.