-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test all virtual environments, not just the latest, and added crontab #60
Conversation
Looks on windows-2016 jruby-9.1/jruby/jruby-head/mswin are all failing, are these known failures which I should exclude? |
jruby seems to fail because tar doesn't seem to be on the expected place on windows-2016 and mswin assumes Visual Studio 2019 which is not there on windows-2016 |
Thanks. The problem is that a native tar.exe exists in Windows 2019, but not Windows 2016. Maybe you can experiment in your fork, as the Git or MSYS2 version may work. I can look at it later... The mswin build is done using VS 2019, I don't think there have been any requests for a VS 2016 build. It's not a common platform, as there are some extension gems that will not compile with MSVC... |
I have updated the test.yml with the updated platforms so that all should work. My first priority is to update all our actions to use this action, maybe someone else can fix jruby on windows-2016 and enable that in the test.yml again |
FWIW It was intentional to run a subset of platforms so the CI is reasonably fast and we don't create so many jobs. 74 jobs is still probably somewhat reasonable (but will result in a lot of queuing), so I'm OK to try with this PR and see how it goes. Note that testing all Ruby versions on all platforms would result in hundreds of jobs and so is completely unrealistic. I don't think it's needed nor very useful either, so the proposed matrix in this PR seems OK. |
Could you rebase this? |
.github/workflows/test.yml
Outdated
- { os: windows-2016, ruby: truffleruby-head } | ||
- { os: windows-2016, ruby: jruby } | ||
- { os: windows-2016, ruby: jruby-9.1 } | ||
- { os: windows-2016, ruby: jruby-head } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3 lines above can be removed now that #61 is fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
* .github/workflows/test.yml:
…pendencies break this * .github/workflows/test.yml:
* .github/workflows/test.yml:
* .github/workflows/test.yml:
* .github/workflows/test.yml:
b345f58
to
e7bbc79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.