Update string/modulo_spec for ruby core changes #401
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. |
eregon
reviewed
Mar 29, 2017
core/string/modulo_spec.rb
Outdated
| ("foo%" % []).should == "foo%" | ||
| it "raises an error if single % appears at the end" do | ||
| lambda { ("%" % []) }.should raise_error(ArgumentError) | ||
| lambda { ("foo%" % [])}.should raise_error(ArgumentError) | ||
| end |
There was a problem hiding this comment.
If the change is merged, it will only applies to trunk initially, and then maybe be backported.
Therefore, could you add a version guard like this
ruby_version_is ""..."2.5" do
old spec
end
ruby_version_is "2.5" do
new spec
end?
|
Matz said this behaviour is OK 👀 https://bugs.ruby-lang.org/issues/13315#note-4 |
|
Yeah! 🎉 |
hsbt
pushed a commit
to ruby/ruby
that referenced
this pull request
May 25, 2017
* Add tests and specs. See ruby/spec#401. Patch by Yuta Iwama and Shintaro Morikawa. [ruby-core:80153] [Bug #13315] [Fix GH-1560] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58890 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
Merged in ruby/ruby@fd8df3a |
eregon
added a commit
that referenced
this pull request
May 27, 2017
* Add tests and specs. See #401. Patch by Yuta Iwama and Shintaro Morikawa. [ruby-core:80153] [Bug 13315] [Fix ruby/ruby#1560] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58890 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
Thank you @eregon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will change
sprintfto raise an error if single "%" character appears at the end.ruby/ruby#1560 (comment)
https://bugs.ruby-lang.org/issues/13315
This pull-request follows the change.
Please review.