recv nonblock specs with a buffer #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Jan 7, 2021
| # TODO: Figure out a good way to test non-blocking. | ||
| IO.select([@socket]) | ||
| buffer = "".b | ||
| @socket.recv_nonblock(50, buffer) |
There was a problem hiding this comment.
It seems those methods need the flags as the second argument, so an extra , 0, for both cases.
There was a problem hiding this comment.
are you sure? According to the docs, the second arg can be either buffer or flags.
There was a problem hiding this comment.
you were right, fixed!
There was a problem hiding this comment.
The CI is still failing, this line wasn't changed it seems.
There was a problem hiding this comment.
https://docs.ruby-lang.org/en/3.0.0/BasicSocket.html#method-i-recv_nonblock
They are all positional (except options), so it seems flags are needed.
There was a problem hiding this comment.
yup, that extra test for tcp socket failed. fixed now.
HoneyryderChuck
force-pushed
the
test-sock-recv-nonblocks-with-buffer
branch
2 times, most recently
from
148adc1
to
5b09df8
Compare
HoneyryderChuck
force-pushed
the
test-sock-recv-nonblocks-with-buffer
branch
from
5b09df8
to
5e0d031
Compare
eregon
reviewed
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per described in oracle/truffleruby#2209 (comment)