Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spec for SortedSet being extracted from the set library #870

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

lxxxvi
Copy link
Contributor

@lxxxvi lxxxvi commented Oct 9, 2021

Hello 👋

From #823

Stdlib updates

Set

SortedSet has been removed for dependency and performance reasons.

and

Compatibility issues

[...]

SortedSet has been removed for dependency and performance reasons.

(It's listed twice 🙃)


I am not really sure how to test this. My idea here is to to add a simple spec for SortedSet.new, asserting to be instance of SortedSet for versions ""..."3.0" and assert to throw an error in version "3.0".

Is there a better way?

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@eregon
Copy link
Member

eregon commented Oct 11, 2021

FWIW this works via autoload, interesting.

@eregon eregon merged commit 96a4617 into ruby:master Oct 11, 2021
@eregon
Copy link
Member

eregon commented Oct 11, 2021

FYI I tweaked it a bit in a2776f4

@lxxxvi lxxxvi deleted the add-spec-for-SortedSet-being-extracted branch October 11, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants