Salvaging 20 years of ruby/tk history #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(As I told @hsbt in person before,) I really hate the way this repo treats the commits from the original repo.
8513179 squashes all 20 years of history of ruby/tk development in just one meaningless commit,
which seems totally disrespectful to the original authors (especially Nagai-sensei), and makes it impossible to code readers to go back through the history and understand the intension behind the code.
So, I salvaged all 700+ tk related commits back to @matz's very first 2e1501d from the original ruby repository.
You can now follow every single change for each file with
git log --follow
.git blame
everywhere on this repo now shows us what we expect.Please note that this PR can't just be merged. What I'd suggest to do with this repo is to abandon the current master branch and force-push this branch as the master branch here, just like I & @mrkn did to https://github.com/ruby/bigdecimal repo.
Those who already cloned this repo may be a little bit confused, but I guess it wouldn't cause a big problem because I guess not that much people will be affected (there're only 2 forks so far, including mine), and it might not be very difficult to switch to the new master (just discard the old master and
git pull
).