treat the default mode of eventloop thread restriction #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…non-main thread", that is, "Thead.new{Tk.mainloo]" works. Probably irb users would prefer to be able to control widgets interactively.
Otherwise, the default mode is "runnable on the main thread only", because "unnable on non-main thread" requires more processing cost.
To make mode selection easier, add a constant ::TK_MAINLOOP_ON_MAIN_THREAD_ONLY. By setting the value of the constant before "require 'tk'", we can select the mode of eventloop.
|
@h-nagai Thanks to your pull-request. I added write permission to you in this repository. @jeremyevans and others: @h-nagai is the original maintainer of ruby-tk library. There is no reason to not add him to maintainers. |
jeremyevans
approved these changes
Nov 7, 2023
|
I'm going to merge this now so it can be included in the upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On irb, the default mode of eventloop thread control is "runnable on non-main thread", that is, "Thead.new{Tk.mainloo]" works. Probably irb users would prefer to be able to control widgets interactively.
Otherwise, the default mode is "runnable on the main thread only", because "unnable on non-main thread" requires more processing cost. To make mode selection easier, add a constant ::TK_MAINLOOP_ON_MAIN_THREAD_ONLY. By setting the value of the constant before "require 'tk'", we can select the mode of eventloop.