Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous spaces at the end of status line #16

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

nobu
Copy link
Member

@nobu nobu commented Mar 10, 2019

Remove extraneous spaces after the status code that is
non-compliant with RFC, i.e HTTP 200 OK , to unnecessary
confusion for WEBrick users, by a risk that WEBrick instances in
the wild will have server responses flagged as suspicious or
malicious due to a similar bug in Cobalt Strike
misconfiguration
.

Reported by Matt Tennis mtennis@paloaltonetworks.com

Remove extraneous spaces after the status code that is
non-compliant with RFC, i.e `HTTP 200 OK `, to unnecessary
confusion for WEBrick users, by a risk that WEBrick instances in
the wild will have server responses flagged as suspicious or
malicious due to a similar bug in [Cobalt Strike
misconfiguration].

Reported by Matt Tennis <mtennis@paloaltonetworks.com>

[Cobalt Strike misconfiguration]: https://blog.fox-it.com/2019/02/26/identifying-cobalt-strike-team-servers-in-the-wild/
@hsbt hsbt merged commit 8e3d872 into ruby:master Jun 21, 2019
plonk added a commit to plonk/genkai that referenced this pull request Jul 6, 2019
応答行がバイトパーフェクトで"HTTP/1.1 200 OK" じゃないと
nicocastで読み込めない。reason phrase のあとに空白を出力するのは
RFCに準拠しないそうだが、WEBrickのmasterに入った修正はリリース
されていない。(参考: ruby/webrick#16)
@nobu nobu deleted the bug/extraneous-space-in-status-line branch August 28, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants