Switch to URI.parse to parse httprequest host line. #84
Conversation
This solves the issue of the use of underscores in a host name. Using URI.parse makes us consistent with its functionality.
|
Underscores are not valid in domain names. Is there a reason we should have webrick support underscores in in host names? Is it to support non-DNS host names (e.g. WINS)? |
|
I do not have a good answer here - underscores work "for me" in any context I use them. I respect that an RFC somewhere may or may not allow them in a domain name. RFC3986 which I believe controls the parsing of a uri and which URI.parse uses as the default parser is fine with the underscore. Webrick currently appears to be using the regexps from the RFC2396 parser within URI. That appears to have issues with the underscore. If there is no desire to go down the URI.parse road (and I grasp/respect/appreciate why there would not be) - would the alternative of moving those 2 lines (494-495) out to a method so I can override the method with the URI.parse concept be at all acceptable? |
|
I am fine with extracting a method to make it easier to extend the behavior. Could you submit a pull request for that? |
|
Moved to #85 |
This solves the issue of the use of underscores in a host name. Using URI.parse makes us consistent with its functionality.