Move the post required parameters after the rest parameter

* See #1436

Author: eregon

config.yml

@@ -1908,11 +1908,11 @@ nodes:
         type: node[]
       - name: optionals
         type: node[]
-      - name: posts
-        type: node[]
       - name: rest
         type: node?
         kind: RestParameterNode
+      - name: posts
+        type: node[]
       - name: keywords
         type: node[]
       - name: keyword_rest

test/yarp/errors_test.rb

@@ -494,7 +494,7 @@ def test_bad_arguments
           RequiredParameterNode(:@a),
           RequiredParameterNode(:$A),
           RequiredParameterNode(:@@a),
-        ], [], [], nil, [], nil, nil),
+        ], [], nil, [], [], nil, nil),
         nil,
         [:A, :@a, :$A, :@@a],
         Location(),
@@ -560,9 +560,9 @@ def test_do_not_allow_trailing_commas_in_method_parameters
         ParametersNode(
           [RequiredParameterNode(:a), RequiredParameterNode(:b), RequiredParameterNode(:c)],
           [],
-          [],
           nil,
           [],
+          [],
           nil,
           nil
         ),
@@ -588,7 +588,7 @@ def test_do_not_allow_trailing_commas_in_lambda_parameters
         Location(),
         Location(),
         BlockParametersNode(
-          ParametersNode([RequiredParameterNode(:a), RequiredParameterNode(:b)], [], [], nil, [], nil, nil),
+          ParametersNode([RequiredParameterNode(:a), RequiredParameterNode(:b)], [], nil, [], [], nil, nil),
           [],
           Location(),
           Location()
@@ -644,8 +644,8 @@ def test_method_parameters_after_block
         ParametersNode(
           [],
           [],
-          [RequiredParameterNode(:a)],
           nil,
+          [RequiredParameterNode(:a)],
           [],
           nil,
           BlockParameterNode(:block, Location(), Location())
@@ -669,7 +669,7 @@ def test_method_with_arguments_after_anonymous_block
         :foo,
         Location(),
         nil,
-        ParametersNode([], [], [RequiredParameterNode(:a)], nil, [], nil, BlockParameterNode(nil, nil, Location())),
+        ParametersNode([], [], nil, [RequiredParameterNode(:a)], [], nil, BlockParameterNode(nil, nil, Location())),
         nil,
         [:&, :a],
         Location(),
@@ -693,8 +693,8 @@ def test_method_parameters_after_arguments_forwarding
         ParametersNode(
           [],
           [],
-          [RequiredParameterNode(:a)],
           nil,
+          [RequiredParameterNode(:a)],
           [],
           ForwardingParameterNode(),
           nil
@@ -721,8 +721,8 @@ def test_keywords_parameters_before_required_parameters
         ParametersNode(
           [],
           [],
-          [RequiredParameterNode(:a)],
           nil,
+          [RequiredParameterNode(:a)],
           [KeywordParameterNode(:b, Location(), nil)],
           nil,
           nil
@@ -747,10 +747,10 @@ def test_rest_keywords_parameters_before_required_parameters
         Location(),
         nil,
         ParametersNode(
-          [],
           [],
           [],
           nil,
+          [],
           [KeywordParameterNode(:b, Location(), nil)],
           KeywordRestParameterNode(:rest, Location(), Location()),
           nil
@@ -775,7 +775,7 @@ def test_double_arguments_forwarding
         :foo,
         Location(),
         nil,
-        ParametersNode([], [], [], nil, [], ForwardingParameterNode(), nil),
+        ParametersNode([], [], nil, [], [], ForwardingParameterNode(), nil),
         nil,
         [:"..."],
         Location(),
@@ -799,8 +799,8 @@ def test_multiple_error_in_parameters_order
         ParametersNode(
           [],
           [],
-          [RequiredParameterNode(:a)],
           nil,
+          [RequiredParameterNode(:a)],
           [KeywordParameterNode(:b, Location(), nil)],
           KeywordRestParameterNode(:args, Location(), Location()),
           nil
@@ -829,8 +829,8 @@ def test_switching_to_optional_arguments_twice
         ParametersNode(
           [],
           [],
-          [RequiredParameterNode(:a)],
           nil,
+          [RequiredParameterNode(:a)],
           [KeywordParameterNode(:b, Location(), nil)],
           KeywordRestParameterNode(:args, Location(), Location()),
           nil
@@ -859,8 +859,8 @@ def test_switching_to_named_arguments_twice
         ParametersNode(
           [],
           [],
-          [RequiredParameterNode(:a)],
           nil,
+          [RequiredParameterNode(:a)],
           [KeywordParameterNode(:b, Location(), nil)],
           KeywordRestParameterNode(:args, Location(), Location()),
           nil
@@ -892,8 +892,8 @@ def test_returning_to_optional_parameters_multiple_times
             OptionalParameterNode(:b, Location(), Location(), IntegerNode(IntegerBaseFlags::DECIMAL)),
             OptionalParameterNode(:d, Location(), Location(), IntegerNode(IntegerBaseFlags::DECIMAL))
           ],
-          [RequiredParameterNode(:c), RequiredParameterNode(:e)],
           nil,
+          [RequiredParameterNode(:c), RequiredParameterNode(:e)],
           [],
           nil,
           nil
@@ -954,7 +954,7 @@ def test_do_not_allow_forward_arguments_in_lambda_literals
         Location(),
         Location(),
         Location(),
-        BlockParametersNode(ParametersNode([], [], [], nil, [], ForwardingParameterNode(), nil), [], Location(), Location()),
+        BlockParametersNode(ParametersNode([], [], nil, [], [], ForwardingParameterNode(), nil), [], Location(), Location()),
         nil
       )
 
@@ -973,7 +973,7 @@ def test_do_not_allow_forward_arguments_in_blocks
         nil,
         BlockNode(
           [:"..."],
-          BlockParametersNode(ParametersNode([], [], [], nil, [], ForwardingParameterNode(), nil), [], Location(), Location()),
+          BlockParametersNode(ParametersNode([], [], nil, [], [], ForwardingParameterNode(), nil), [], Location(), Location()),
           nil,
           Location(),
           Location()
@@ -1046,7 +1046,7 @@ def test_duplicated_parameter_names
           :foo,
           Location(),
           nil,
-          ParametersNode([RequiredParameterNode(:a), RequiredParameterNode(:b), RequiredParameterNode(:a)], [], [], nil, [], nil, nil),
+          ParametersNode([RequiredParameterNode(:a), RequiredParameterNode(:b), RequiredParameterNode(:a)], [], nil, [], [], nil, nil),
           nil,
           [:a, :b],
           Location(),
@@ -1066,7 +1066,7 @@ def test_duplicated_parameter_names
         :foo,
         Location(),
         nil,
-        ParametersNode([RequiredParameterNode(:a), RequiredParameterNode(:b)], [], [], RestParameterNode(:a, Location(), Location()), [], nil, nil),
+        ParametersNode([RequiredParameterNode(:a), RequiredParameterNode(:b)], [], RestParameterNode(:a, Location(), Location()), [], [], nil, nil),
         nil,
         [:a, :b],
         Location(),
@@ -1085,7 +1085,7 @@ def test_duplicated_parameter_names
         :foo,
         Location(),
         nil,
-        ParametersNode([RequiredParameterNode(:a), RequiredParameterNode(:b)], [], [], nil, [], KeywordRestParameterNode(:a, Location(), Location()), nil),
+        ParametersNode([RequiredParameterNode(:a), RequiredParameterNode(:b)], [], nil, [], [], KeywordRestParameterNode(:a, Location(), Location()), nil),
         nil,
         [:a, :b],
         Location(),
@@ -1104,7 +1104,7 @@ def test_duplicated_parameter_names
         :foo,
         Location(),
         nil,
-        ParametersNode([RequiredParameterNode(:a), RequiredParameterNode(:b)], [], [], nil, [], nil, BlockParameterNode(:a, Location(), Location())),
+        ParametersNode([RequiredParameterNode(:a), RequiredParameterNode(:b)], [], nil, [], [], nil, BlockParameterNode(:a, Location(), Location())),
         nil,
         [:a, :b],
         Location(),
@@ -1123,7 +1123,7 @@ def test_duplicated_parameter_names
         :foo,
         Location(),
         nil,
-        ParametersNode([], [OptionalParameterNode(:a, Location(), Location(), IntegerNode(IntegerBaseFlags::DECIMAL))], [RequiredParameterNode(:b)], RestParameterNode(:c, Location(), Location()), [], nil, nil),
+        ParametersNode([], [OptionalParameterNode(:a, Location(), Location(), IntegerNode(IntegerBaseFlags::DECIMAL))], RestParameterNode(:c, Location(), Location()), [RequiredParameterNode(:b)], [], nil, nil),
         nil,
         [:a, :b, :c],
         Location(),