Constants on keyword parameters

Author: kddnewton

config.yml

@@ -1558,6 +1558,8 @@ nodes:
               ^^^^
   - name: KeywordParameterNode
     fields:
+      - name: name
+        type: constant
       - name: name_loc
         type: location
       - name: value

lib/yarp.rb

@@ -542,8 +542,8 @@ def self.yarp_locals(source)
               *params.optionals.map(&:name),
               *((params.rest.name ? params.rest.name.to_sym : :*) if params.rest && params.rest.operator != ","),
               *params.posts.grep(RequiredParameterNode).map(&:name),
-              *params.keywords.reject(&:value).map { |param| param.name.chomp(":").to_sym },
-              *params.keywords.select(&:value).map { |param| param.name.chomp(":").to_sym }
+              *params.keywords.reject(&:value).map(&:name),
+              *params.keywords.select(&:value).map(&:name)
             ]
 
             # TODO: When we get a ... parameter, we should be pushing * and &

src/yarp.c

@@ -3069,6 +3069,7 @@ yp_keyword_parameter_node_create(yp_parser_t *parser, const yp_token_t *name, yp
                 .end = value == NULL ? name->end : value->location.end
             },
         },
+        .name = yp_parser_constant_id_location(parser, name->start, name->end - 1),
         .name_loc = YP_LOCATION_TOKEN_VALUE(name),
         .value = value
     };

test/yarp/errors_test.rb

@@ -716,7 +716,7 @@ def test_keywords_parameters_before_required_parameters
           [],
           [RequiredParameterNode(:a)],
           nil,
-          [KeywordParameterNode(Location(), nil)],
+          [KeywordParameterNode(:b, Location(), nil)],
           nil,
           nil
         ),
@@ -743,7 +743,7 @@ def test_rest_keywords_parameters_before_required_parameters
           [],
           [],
           nil,
-          [KeywordParameterNode(Location(), nil)],
+          [KeywordParameterNode(:b, Location(), nil)],
           KeywordRestParameterNode(Location(), Location()),
           nil
         ),
@@ -790,7 +790,7 @@ def test_multiple_error_in_parameters_order
           [],
           [RequiredParameterNode(:a)],
           nil,
-          [KeywordParameterNode(Location(), nil)],
+          [KeywordParameterNode(:b, Location(), nil)],
           KeywordRestParameterNode(Location(), Location()),
           nil
         ),
@@ -819,7 +819,7 @@ def test_switching_to_optional_arguments_twice
           [],
           [RequiredParameterNode(:a)],
           nil,
-          [KeywordParameterNode(Location(), nil)],
+          [KeywordParameterNode(:b, Location(), nil)],
           KeywordRestParameterNode(Location(), Location()),
           nil
         ),
@@ -848,7 +848,7 @@ def test_switching_to_named_arguments_twice
           [],
           [RequiredParameterNode(:a)],
           nil,
-          [KeywordParameterNode(Location(), nil)],
+          [KeywordParameterNode(:b, Location(), nil)],
           KeywordRestParameterNode(Location(), Location()),
           nil
         ),