Add constants and constants

Author: kddnewton

config.yml

@@ -867,6 +867,8 @@ nodes:
           ^^^^^^^^^
   - name: ConstantAndWriteNode
     fields:
+      - name: name
+        type: constant
       - name: name_loc
         type: location
       - name: operator_loc
@@ -880,6 +882,8 @@ nodes:
           ^^^^^^^^^^^^^^^^
   - name: ConstantOperatorWriteNode
     fields:
+      - name: name
+        type: constant
       - name: name_loc
         type: location
       - name: operator_loc
@@ -895,6 +899,8 @@ nodes:
           ^^^^^^^^^^^^^^^
   - name: ConstantOrWriteNode
     fields:
+      - name: name
+        type: constant
       - name: name_loc
         type: location
       - name: operator_loc
@@ -997,19 +1003,27 @@ nodes:
           ::Foo::Bar = 1
           ^^^^^^^^^^^^^^
   - name: ConstantReadNode
+    fields:
+      - name: name
+        type: constant
     comment: |
       Represents referencing a constant.
 
           Foo
           ^^^
   - name: ConstantTargetNode
+    fields:
+      - name: name
+        type: constant
     comment: |
       Represents writing to a constant in a context that doesn't have an explicit value.
 
           Foo, Bar = baz
           ^^^  ^^^
   - name: ConstantWriteNode
     fields:
+      - name: name
+        type: constant
       - name: name_loc
         type: location
       - name: value

lib/yarp/desugar_visitor.rb

@@ -8,7 +8,7 @@ class DesugarVisitor < MutationVisitor
     #
     # @@foo && @@foo = bar
     def visit_class_variable_and_write_node(node)
-      desugar_and_write_node(node, ClassVariableReadNode, ClassVariableWriteNode, arguments: [node.name])
+      desugar_and_write_node(node, ClassVariableReadNode, ClassVariableWriteNode, node.name)
     end
 
     # @@foo ||= bar
@@ -17,7 +17,7 @@ def visit_class_variable_and_write_node(node)
     #
     # defined?(@@foo) ? @@foo : @@foo = bar
     def visit_class_variable_or_write_node(node)
-      desugar_or_write_defined_node(node, ClassVariableReadNode, ClassVariableWriteNode, arguments: [node.name])
+      desugar_or_write_defined_node(node, ClassVariableReadNode, ClassVariableWriteNode, node.name)
     end
 
     # @@foo += bar
@@ -26,7 +26,7 @@ def visit_class_variable_or_write_node(node)
     #
     # @@foo = @@foo + bar
     def visit_class_variable_operator_write_node(node)
-      desugar_operator_write_node(node, ClassVariableReadNode, ClassVariableWriteNode, arguments: [node.name])
+      desugar_operator_write_node(node, ClassVariableReadNode, ClassVariableWriteNode, node.name)
     end
 
     # Foo &&= bar
@@ -35,7 +35,7 @@ def visit_class_variable_operator_write_node(node)
     #
     # Foo && Foo = bar
     def visit_constant_and_write_node(node)
-      desugar_and_write_node(node, ConstantReadNode, ConstantWriteNode)
+      desugar_and_write_node(node, ConstantReadNode, ConstantWriteNode, node.name)
     end
 
     # Foo ||= bar
@@ -44,7 +44,7 @@ def visit_constant_and_write_node(node)
     #
     # defined?(Foo) ? Foo : Foo = bar
     def visit_constant_or_write_node(node)
-      desugar_or_write_defined_node(node, ConstantReadNode, ConstantWriteNode)
+      desugar_or_write_defined_node(node, ConstantReadNode, ConstantWriteNode, node.name)
     end
 
     # Foo += bar
@@ -53,7 +53,7 @@ def visit_constant_or_write_node(node)
     #
     # Foo = Foo + bar
     def visit_constant_operator_write_node(node)
-      desugar_operator_write_node(node, ConstantReadNode, ConstantWriteNode)
+      desugar_operator_write_node(node, ConstantReadNode, ConstantWriteNode, node.name)
     end
 
     # $foo &&= bar
@@ -62,7 +62,7 @@ def visit_constant_operator_write_node(node)
     #
     # $foo && $foo = bar
     def visit_global_variable_and_write_node(node)
-      desugar_and_write_node(node, GlobalVariableReadNode, GlobalVariableWriteNode, arguments: [node.name])
+      desugar_and_write_node(node, GlobalVariableReadNode, GlobalVariableWriteNode, node.name)
     end
 
     # $foo ||= bar
@@ -71,7 +71,7 @@ def visit_global_variable_and_write_node(node)
     #
     # defined?($foo) ? $foo : $foo = bar
     def visit_global_variable_or_write_node(node)
-      desugar_or_write_defined_node(node, GlobalVariableReadNode, GlobalVariableWriteNode, arguments: [node.name])
+      desugar_or_write_defined_node(node, GlobalVariableReadNode, GlobalVariableWriteNode, node.name)
     end
 
     # $foo += bar
@@ -80,7 +80,7 @@ def visit_global_variable_or_write_node(node)
     #
     # $foo = $foo + bar
     def visit_global_variable_operator_write_node(node)
-      desugar_operator_write_node(node, GlobalVariableReadNode, GlobalVariableWriteNode, arguments: [node.name])
+      desugar_operator_write_node(node, GlobalVariableReadNode, GlobalVariableWriteNode, node.name)
     end
 
     # @foo &&= bar
@@ -89,7 +89,7 @@ def visit_global_variable_operator_write_node(node)
     #
     # @foo && @foo = bar
     def visit_instance_variable_and_write_node(node)
-      desugar_and_write_node(node, InstanceVariableReadNode, InstanceVariableWriteNode, arguments: [node.name])
+      desugar_and_write_node(node, InstanceVariableReadNode, InstanceVariableWriteNode, node.name)
     end
 
     # @foo ||= bar
@@ -98,7 +98,7 @@ def visit_instance_variable_and_write_node(node)
     #
     # @foo || @foo = bar
     def visit_instance_variable_or_write_node(node)
-      desugar_or_write_node(node, InstanceVariableReadNode, InstanceVariableWriteNode, arguments: [node.name])
+      desugar_or_write_node(node, InstanceVariableReadNode, InstanceVariableWriteNode, node.name)
     end
 
     # @foo += bar
@@ -107,7 +107,7 @@ def visit_instance_variable_or_write_node(node)
     #
     # @foo = @foo + bar
     def visit_instance_variable_operator_write_node(node)
-      desugar_operator_write_node(node, InstanceVariableReadNode, InstanceVariableWriteNode, arguments: [node.name])
+      desugar_operator_write_node(node, InstanceVariableReadNode, InstanceVariableWriteNode, node.name)
     end
 
     # foo &&= bar
@@ -116,7 +116,7 @@ def visit_instance_variable_operator_write_node(node)
     #
     # foo && foo = bar
     def visit_local_variable_and_write_node(node)
-      desugar_and_write_node(node, LocalVariableReadNode, LocalVariableWriteNode, arguments: [node.name, node.depth])
+      desugar_and_write_node(node, LocalVariableReadNode, LocalVariableWriteNode, node.name, node.depth)
     end
 
     # foo ||= bar
@@ -125,7 +125,7 @@ def visit_local_variable_and_write_node(node)
     #
     # foo || foo = bar
     def visit_local_variable_or_write_node(node)
-      desugar_or_write_node(node, LocalVariableReadNode, LocalVariableWriteNode, arguments: [node.name, node.depth])
+      desugar_or_write_node(node, LocalVariableReadNode, LocalVariableWriteNode, node.name, node.depth)
     end
 
     # foo += bar
@@ -134,13 +134,13 @@ def visit_local_variable_or_write_node(node)
     #
     # foo = foo + bar
     def visit_local_variable_operator_write_node(node)
-      desugar_operator_write_node(node, LocalVariableReadNode, LocalVariableWriteNode, arguments: [node.name, node.depth])
+      desugar_operator_write_node(node, LocalVariableReadNode, LocalVariableWriteNode, node.name, node.depth)
     end
 
     private
 
     # Desugar `x &&= y` to `x && x = y`
-    def desugar_and_write_node(node, read_class, write_class, arguments: [])
+    def desugar_and_write_node(node, read_class, write_class, *arguments)
       AndNode.new(
         read_class.new(*arguments, node.name_loc),
         write_class.new(*arguments, node.name_loc, node.value, node.operator_loc, node.location),
@@ -150,7 +150,7 @@ def desugar_and_write_node(node, read_class, write_class, arguments: [])
     end
 
     # Desugar `x += y` to `x = x + y`
-    def desugar_operator_write_node(node, read_class, write_class, arguments: [])
+    def desugar_operator_write_node(node, read_class, write_class, *arguments)
       write_class.new(
         *arguments,
         node.name_loc,
@@ -172,7 +172,7 @@ def desugar_operator_write_node(node, read_class, write_class, arguments: [])
     end
 
     # Desugar `x ||= y` to `x || x = y`
-    def desugar_or_write_node(node, read_class, write_class, arguments: [])
+    def desugar_or_write_node(node, read_class, write_class, *arguments)
       OrNode.new(
         read_class.new(*arguments, node.name_loc),
         write_class.new(*arguments, node.name_loc, node.value, node.operator_loc, node.location),
@@ -182,7 +182,7 @@ def desugar_or_write_node(node, read_class, write_class, arguments: [])
     end
 
     # Desugar `x ||= y` to `defined?(x) ? x : x = y`
-    def desugar_or_write_defined_node(node, read_class, write_class, arguments: [])
+    def desugar_or_write_defined_node(node, read_class, write_class, *arguments)
       IfNode.new(
         node.operator_loc,
         DefinedNode.new(nil, read_class.new(*arguments, node.name_loc), nil, node.operator_loc, node.name_loc),