Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include parallel test libraries integration docs #35

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

iMacTia
Copy link
Contributor

@iMacTia iMacTia commented Sep 14, 2022

Include additional information in the README on how to correctly integrate Stimpack with parallel_tests and knapsack. Fixes #30

Include additional information in the README on how to correctly integrate Stimpack with `parallel_tests` and `knapsack`.
Fixes rubyatscale#30
Copy link
Contributor

@alexevanczuk alexevanczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! @ngan and his team have been doing a lot of work with knapsack pro so just want to give him a chance to chime in on any documentation here regarding knapsack pro.

@iMacTia
Copy link
Contributor Author

iMacTia commented Sep 14, 2022

That's great to hear!
I have been struggling a lot with making the new RSpec integration work with Knapsack, and I'm not even sure my solution is the best one, it's simple the only one I could find that works 😂.
I'd love to hear more from @ngan and maybe even learn of a better way to make it work 😄

README.md Outdated Show resolved Hide resolved
Co-authored-by: Oleg Smelov <79197369+oleg-vinted@users.noreply.github.com>
Copy link

@baweaver baweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for taking a look into that!

@baweaver baweaver merged commit 6d46bf1 into rubyatscale:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parallel_tests gem support
4 participants